Fix failure in PanoramaWebPublicSearchTest due to invalid URL parameters #596
+9
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
@labkey-jeckels shouldn't this use client-side helpers to build URLs to avoid these kinds of problems? |
Contributor
Author
Yes, it should. However, the code I modified is using GET parameter-style values and appending them to the hash part of the URL by appending to window.location.href. ActionURL isn't built to do this. As much as I'd like to refactor a good chunk of this file, I didn't want to tackle it. |
ankurjuneja
approved these changes
Jan 22, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale
https://teamcity.labkey.org/buildConfiguration/bt310/3814947?buildTab=tests&status=failed&suite=org.labkey.test.Runner%3A+&package=org.labkey.test.tests.panoramapublic&class=PanoramaWebPublicSearchTest
We're generating invalid URLs with empty GET parameters. Example snippet:
&Targeted%20MS%20Experiment%20List.authors~containsoneof=Doe&=&dataRegionName=Targeted%20MS%20Experiment%20ListTomcat 11 has gotten stricter about validating the URL structure.
Changes
&when we may not need the separator